refactor: Migrate usages of py_internal.cc_helper to @rules_cc#3455
refactor: Migrate usages of py_internal.cc_helper to @rules_cc#3455hvadehra wants to merge 1 commit intobazel-contrib:mainfrom
py_internal.cc_helper to @rules_cc#3455Conversation
Summary of ChangesHello @hvadehra, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring effort to update the Bazel build configuration by transitioning from an internal Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the code to migrate from the internal py_internal.cc_helper to the public APIs provided by @rules_cc. This is a great improvement for long-term maintainability, especially with the upcoming removal of built-in symbols in Bazel 9. The changes are clean, correct, and well-contained. I've reviewed the modifications in BUILD.bazel, common.bzl, and py_executable.bzl and they all look good. Excellent work!
a085c2e to
dfa8aab
Compare
The builtins symbols are deleted in Bazel 9